From 572fe3239320c0863ac9b24cdde1cdd8c7aab9a6 Mon Sep 17 00:00:00 2001 From: Jared Boone Date: Mon, 10 Nov 2014 11:10:18 -0800 Subject: [PATCH 1/5] Add #include to address "sgpio_cpld_stream_rx_set_q_invert" warning. --- firmware/common/tuning.c | 1 + 1 file changed, 1 insertion(+) diff --git a/firmware/common/tuning.c b/firmware/common/tuning.c index 651c8bb9..6bbe4cd1 100644 --- a/firmware/common/tuning.c +++ b/firmware/common/tuning.c @@ -24,6 +24,7 @@ #include #include +#include #define FREQ_ONE_MHZ (1000*1000) From 9bf640895f06f89a62cdc93e386272893e81cd11 Mon Sep 17 00:00:00 2001 From: Jared Boone Date: Mon, 10 Nov 2014 11:11:49 -0800 Subject: [PATCH 2/5] Quiet warning about unused args in cpld_buffer_refilled(). --- firmware/hackrf_usb/usb_api_cpld.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/firmware/hackrf_usb/usb_api_cpld.c b/firmware/hackrf_usb/usb_api_cpld.c index e29007c5..cc9daa0f 100644 --- a/firmware/hackrf_usb/usb_api_cpld.c +++ b/firmware/hackrf_usb/usb_api_cpld.c @@ -40,6 +40,8 @@ volatile bool cpld_wait = false; static void cpld_buffer_refilled(void* user_data, unsigned int length) { + (void)user_data; + (void)length; cpld_wait = false; } From 75d194e48b88e93ef55d4e9e105c00f66c48cc24 Mon Sep 17 00:00:00 2001 From: Jared Boone Date: Mon, 10 Nov 2014 11:15:01 -0800 Subject: [PATCH 3/5] Quiet warning about unused arg in xsvfInfoCleanup(). --- firmware/common/xapp058/micro.c | 1 + 1 file changed, 1 insertion(+) diff --git a/firmware/common/xapp058/micro.c b/firmware/common/xapp058/micro.c index 227a4824..f4b4db45 100644 --- a/firmware/common/xapp058/micro.c +++ b/firmware/common/xapp058/micro.c @@ -454,6 +454,7 @@ int xsvfInfoInit( SXsvfInfo* pXsvfInfo ) *****************************************************************************/ void xsvfInfoCleanup( SXsvfInfo* pXsvfInfo ) { + (void)pXsvfInfo; } /***************************************************************************** From e3a841ca24b1125c426d432b72f4618b563d2467 Mon Sep 17 00:00:00 2001 From: Jared Boone Date: Mon, 10 Nov 2014 11:16:39 -0800 Subject: [PATCH 4/5] XSVF: Fix apparent #ifdef scope bug in xsvfDoXCOMMENT() where comments aren't truly ignored. --- firmware/common/xapp058/micro.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/firmware/common/xapp058/micro.c b/firmware/common/xapp058/micro.c index f4b4db45..501d1024 100644 --- a/firmware/common/xapp058/micro.c +++ b/firmware/common/xapp058/micro.c @@ -1560,16 +1560,18 @@ int xsvfDoXCOMMENT( SXsvfInfo* pXsvfInfo ) { putchar( ' ' ); } - +#endif + do { readByte( &ucText ); +#ifdef DEBUG_MODE if ( xsvf_iDebugLevel > 0 ) { putchar( ucText ? ucText : '\n' ); } - } while ( ucText ); #endif + } while ( ucText ); pXsvfInfo->iErrorCode = XSVF_ERROR_NONE; From 256d6ccef0dfe3f8b00080744eab1cffd6b410ff Mon Sep 17 00:00:00 2001 From: Jared Boone Date: Mon, 10 Nov 2014 11:19:50 -0800 Subject: [PATCH 5/5] Re-scope buffer[] to solve unread array warning. --- firmware/sgpio/sgpio_test.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/firmware/sgpio/sgpio_test.c b/firmware/sgpio/sgpio_test.c index 802129db..6e391c10 100644 --- a/firmware/sgpio/sgpio_test.c +++ b/firmware/sgpio/sgpio_test.c @@ -30,17 +30,18 @@ #include #include +volatile uint32_t buffer[4096]; + void tx_test() { sgpio_set_slice_mode(false); sgpio_configure(TRANSCEIVER_MODE_TX); // LSB goes out first, samples are 0x - volatile uint32_t buffer[] = { - 0xda808080, - 0xda80ff80, - 0x26808080, - 0x26800180, - }; + buffer[0] = 0xda808080; + buffer[1] = 0xda80ff80; + buffer[2] = 0x26808080; + buffer[3] = 0x26800180; + uint32_t i = 0; sgpio_cpld_stream_enable(); @@ -56,7 +57,6 @@ void rx_test() { sgpio_set_slice_mode(false); sgpio_configure(TRANSCEIVER_MODE_RX); - volatile uint32_t buffer[4096]; uint32_t i = 0; sgpio_cpld_stream_enable();