From 74fb86f8bc89ae9f30a56d8b1b0e7177f7b43bc4 Mon Sep 17 00:00:00 2001 From: Michael Ossmann Date: Wed, 10 Nov 2021 09:22:08 -0700 Subject: [PATCH] Do not set USB device address to zero (#987) When setting the USB configuration to zero return from the configured state to the address state according to the USB specification. --- firmware/common/usb_standard_request.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/firmware/common/usb_standard_request.c b/firmware/common/usb_standard_request.c index dd763862..51d2ca29 100644 --- a/firmware/common/usb_standard_request.c +++ b/firmware/common/usb_standard_request.c @@ -274,10 +274,6 @@ static usb_request_status_t usb_standard_request_set_configuration_setup( ) { const uint8_t usb_configuration = endpoint->setup.value_l; if( usb_set_configuration(endpoint->device, usb_configuration) ) { - if( usb_configuration == 0 ) { - // TODO: Should this be done immediately? - usb_set_address_immediate(endpoint->device, 0); - } usb_transfer_schedule_ack(endpoint->in); return USB_REQUEST_STATUS_OK; } else {